[GitHub] [kafka] dengziming commented on pull request #10598: MINOR: rename wrong topic id variable name and description

2021-04-27 Thread GitBox
dengziming commented on pull request #10598: URL: https://github.com/apache/kafka/pull/10598#issuecomment-828185212 > @dengziming nice improvement. LGTM > > BTW, line#203 (https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/tools/ConsoleConsumer.scala#L203) has weir

[GitHub] [kafka] dengziming commented on pull request #10598: MINOR: rename wrong topic id variable name and description

2021-04-27 Thread GitBox
dengziming commented on pull request #10598: URL: https://github.com/apache/kafka/pull/10598#issuecomment-827554412 @showuon Thank you, I also think it's not reasonable to fix it here since there are also some other occurrence, so I revert the JMap change. -- This is an automated message