[GitHub] [kafka] dengziming commented on pull request #10701: KAFKA-10437; Fix omitted TODO of KIP-478

2021-06-10 Thread GitBox
dengziming commented on pull request #10701: URL: https://github.com/apache/kafka/pull/10701#issuecomment-858337829 Hello @mjsax , I mean the TDDO at

[GitHub] [kafka] dengziming commented on pull request #10701: KAFKA-10437; Fix omitted TODO of KIP-478

2021-05-25 Thread GitBox
dengziming commented on pull request #10701: URL: https://github.com/apache/kafka/pull/10701#issuecomment-847753120 @mjsax @guozhangwang , how do you think about this approach? In fact, I'm not very confident about this change since it isn't very elegant, but this can remove the TODO,

[GitHub] [kafka] dengziming commented on pull request #10701: KAFKA-10437; Fix omitted TODO of KIP-478

2021-05-14 Thread GitBox
dengziming commented on pull request #10701: URL: https://github.com/apache/kafka/pull/10701#issuecomment-841594749 Hello @vvcephei, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the