[GitHub] [kafka] dengziming commented on pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-29 Thread GitBox
dengziming commented on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1081771550 @dajac @showuon Thank you for the reminder about consistency, I just think printing them is an optimization and I am not very insistent on that. Since consistency is more im

[GitHub] [kafka] dengziming commented on pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-23 Thread GitBox
dengziming commented on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1076366161 > Is this related to the failure we saw here Sadly not, the [failure]( https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-11900/4/tests

[GitHub] [kafka] dengziming commented on pull request #11936: MINOR: Fix an incompatible bug in GetOffsetShell

2022-03-22 Thread GitBox
dengziming commented on pull request #11936: URL: https://github.com/apache/kafka/pull/11936#issuecomment-1075985661 Hello, @dajac @showuon , PLTA. do you think it's better to show a "-1" offset? -- This is an automated message from the Apache Git Service. To respond to the message, ple