dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1128357555
Resolve conflicts, and I also changed `ZkAdminManager.createTopics` to throw
`ConfigException` on null config values.
--
This is an automated message from the Apache Git Service.
To
dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1126924495
@hachikuji Thank you for your suggestions, I have resolved them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1125579394
> Are you saying that in KRaft, we ignore null config values instead of
failing topic creation?
Yes, We will pass the topic configs to `ConfigurationControlManager` in
which nul
dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1118264999
@cmccabe, Yeah, it's unnecessary to change `ReplicationControlManager`,
however, there is still a difference, in KRaft mode, the null config value is
treated as removing configs, so cr
dengziming commented on PR #12109:
URL: https://github.com/apache/kafka/pull/12109#issuecomment-1116766320
Hello @hachikuji @divijvaidya @akhileshchg, another bug when reviewing and
fixing #12106, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message
