[GitHub] [kafka] dengziming commented on pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

2021-01-05 Thread GitBox
dengziming commented on pull request #9649: URL: https://github.com/apache/kafka/pull/9649#issuecomment-754638476 @chia7712 I tried to rebase my pr and push it again, but still failed. this is weird, maybe I triggered a bug of jenkins and should tried again tomorrow.

[GitHub] [kafka] dengziming commented on pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

2020-12-30 Thread GitBox
dengziming commented on pull request #9649: URL: https://github.com/apache/kafka/pull/9649#issuecomment-752820081 @chia7712 ,Thank you for your suggestion. In fact, I get the idea from `AlterIsrManagerTest.testPartitionErrors` which test 3 errors in a method, so I also merge the 3 top

[GitHub] [kafka] dengziming commented on pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

2020-12-14 Thread GitBox
dengziming commented on pull request #9649: URL: https://github.com/apache/kafka/pull/9649#issuecomment-745013161 @mumrah Hi, Davad, PTAL. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dengziming commented on pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

2020-12-04 Thread GitBox
dengziming commented on pull request #9649: URL: https://github.com/apache/kafka/pull/9649#issuecomment-739116990 @mumrah Hi, this class is created by you so I think you can have a look, thank you. This is an automated

[GitHub] [kafka] dengziming commented on pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

2020-11-24 Thread GitBox
dengziming commented on pull request #9649: URL: https://github.com/apache/kafka/pull/9649#issuecomment-733448084 @cmccabe hi, PTAL. This is an automated message from the Apache Git Service. To respond to the message,