dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-764219186
> https://github.com/apache/kafka/pull/9769#issuecomment-764014519
@rajinisivaram @jolshan I also realized this, we add topicId in
`MetadataCache` from IBP=2.8.1, so inst
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-764402380
@rajinisivaram I rebased the code and added a test in
`PlaintextAdminIntegrationTest`, PTAL.
This is an automa
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-765133359
Hello, @rajinisivaram , I resolved the comments/questions and fixed the
NullPointerExceptions, call for a third review.
1. Add topicId to`TopicListing ` and add `TopicComman
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-764219186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-769771773
@rajinisivaram I triggered the QA again but still has some failures, it
seems the failure is unrelated to this pr since other PRs also have these
failures.
--
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-769911317
@rajinisivaram Thank you, I think the problem comes from
`EasyMock.expect(authorizer.authorize(anyObject[RequestContext],
EasyMock.eq(expectedActions.asJava)))`.
below is wh
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770140196
The 2 failures in
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9769/22/ seem to be
related to Mockito, maybe #10006 will fix it. @rajinisivaram PTAL.
--
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770761700
@rajinisivaram I haven't run any system tests and I will try to run some
system tests later.
This is an autom
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-770763376
@rajinisivaram I haven't run any system tests and I will try to run some
system tests later. Should I run the 2 python script locally and analyze the
logs?
--
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-771340522
@rajinisivaram I run
`TC_PATHS="tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py"
bash tests/docker/run_tests.sh` locally on the `trunk branch` versio
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-771340522
@rajinisivaram I run
`TC_PATHS="tests/kafkatest/tests/client/client_compatibility_produce_consume_test.py"
bash tests/docker/run_tests.sh` locally on the `trunk branch` versio
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-772956211
@rajinisivaram @jolshan , Thank you for your effort, I pay attention to the
2.8 release and update this pr.
Th
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-863736540
Check KAFKA-12701 and bump the version of the
MetadataRequest/MetadataResponse, @rajinisivaram @jolshan PTAL.
--
This is an automated message from the Apache Git Service.
To
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-875209647
Replace deprecated methods and rebase on trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-887949936
@rajinisivaram Are you interested in taking this across finish line? I think
this has something that is very close to a first version, we can try to land
that and then improvis
dengziming commented on pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#issuecomment-817051364
@rajinisivaram @jolshan , Currently we have startd merge pr for 3.0, so it's
time to take a look at this again, also #9684 since part of it has been
reverted, thank you.
--
16 matches
Mail list logo
