[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10388: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-03-25 Thread GitBox
dhruvilshah3 commented on a change in pull request #10388: URL: https://github.com/apache/kafka/pull/10388#discussion_r601867771 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -700,11 +700,13 @@ class Log(@volatile private var _dir: File, case _:

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10388: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-03-25 Thread GitBox
dhruvilshah3 commented on a change in pull request #10388: URL: https://github.com/apache/kafka/pull/10388#discussion_r601867672 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -700,11 +700,13 @@ class Log(@volatile private var _dir: File, case _:

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10388: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-03-25 Thread GitBox
dhruvilshah3 commented on a change in pull request #10388: URL: https://github.com/apache/kafka/pull/10388#discussion_r601867171 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -322,17 +323,14 @@ class LogSegment private[log] (val log: FileRecords,

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #10388: KAFKA-12520: Ensure log loading does not truncate producer state unless required

2021-03-25 Thread GitBox
dhruvilshah3 commented on a change in pull request #10388: URL: https://github.com/apache/kafka/pull/10388#discussion_r601865901 ## File path: core/src/main/scala/kafka/log/LogSegment.scala ## @@ -322,17 +323,14 @@ class LogSegment private[log] (val log: FileRecords,