[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r1039472517 ## clients/src/main/java/org/apache/kafka/common/network/Selector.java: ## @@ -809,6 +810,13 @@ private void maybeCloseOldestConnection(long currentTimeNanos) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r952819611 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java: ## @@ -342,6 +342,7 @@ public void reauthenticate(Reauthenticat

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r952810999 ## core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java: ## @@ -147,11 +147,14 @@ public ReplicaManagerBuilder setThreadNamePrefix(String threadNameP

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r952807299 ## clients/src/main/java/org/apache/kafka/common/network/PlaintextChannelBuilder.java: ## @@ -54,12 +54,18 @@ public void configure(Map configs) throws KafkaExcepti

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r903557818 ## clients/src/main/java/org/apache/kafka/common/network/Selector.java: ## @@ -809,6 +810,13 @@ private void maybeCloseOldestConnection(long currentTimeNanos) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r902801885 ## clients/src/main/java/org/apache/kafka/common/network/Selector.java: ## @@ -809,6 +810,13 @@ private void maybeCloseOldestConnection(long currentTimeNanos) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r902792942 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java: ## @@ -567,12 +577,12 @@ private boolean flushNetOutBuffer() th

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r900281799 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -162,79 +163,82 @@ private static FilterResult filterTo(TopicPartition partition,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r900273507 ## clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java: ## @@ -567,12 +577,12 @@ private boolean flushNetOutBuffer() th

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r900273174 ## clients/src/main/java/org/apache/kafka/common/network/Selector.java: ## @@ -809,6 +810,13 @@ private void maybeCloseOldestConnection(long currentTimeNanos) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r885632423 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -595,57 +595,65 @@ private WorkerTask buildWorkerTask(ClusterConfigState config

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12228: KAFKA-13950: Fix resource leaks

divijvaidya commented on code in PR #12228: URL: https://github.com/apache/kafka/pull/12228#discussion_r885628853 ## clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java: ## @@ -162,79 +163,82 @@ private static FilterResult filterTo(TopicPartition partition,