[GitHub] [kafka] divijvaidya commented on a diff in pull request #12281: KAFKA-13971: Fix atomicity violations caused by improper usage of ConcurrentHashMap - part2

2022-08-04 Thread GitBox
divijvaidya commented on code in PR #12281: URL: https://github.com/apache/kafka/pull/12281#discussion_r937504331 ## streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecordingTrigger.java: ## @@ -32,12 +32,12 @@ public RocksDBMetricsRecordingT

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12281: KAFKA-13971: Fix atomicity violations caused by improper usage of ConcurrentHashMap - part2

2022-06-22 Thread GitBox
divijvaidya commented on code in PR #12281: URL: https://github.com/apache/kafka/pull/12281#discussion_r903755896 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -222,14 +222,10 @@ protected PluginClassLoader newPlugi