divijvaidya commented on code in PR #12480:
URL: https://github.com/apache/kafka/pull/12480#discussion_r937932086
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -217,7 +213,7 @@ class DynamicBrokerReconfigurationTest extends
QuorumTestHarness with SaslSetup
keyStoreProps.forEach { configName =>
val desc = configEntry(configDesc, s"$prefix$configName")
val isSensitive = configName.contains("password")
- verifyConfig(configName, desc, isSensitive, isReadOnly =
prefix.nonEmpty, if (prefix.isEmpty) invalidSslProperties else sslProperties1)
+ verifyConfig(configName, desc, isSensitive, isReadOnly =
prefix.nonEmpty, expectedProps)
Review Comment:
nice!
##########
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##########
@@ -1249,7 +1244,7 @@ class DynamicBrokerReconfigurationTest extends
QuorumTestHarness with SaslSetup
verifyTimeout(consumerFuture)
}
- private def verifyListener(securityProtocol: SecurityProtocol,
saslMechanism: Option[String], groupId: String): Unit = {
+ private def verifyListener(securityProtocol: SecurityProtocol,
saslMechanism: Option[String]): Unit = {
Review Comment:
Instead of removing the group as a parameter (I understand that it is
unused), please fix the validation by adding the group ID in the consumer below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
