[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235807347 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -75,31 +75,31 @@ import org.mockito.invocation.InvocationOnMock import

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235094378 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4935,12 +4991,17 @@ class ReplicaManagerTest { topicPartition, leaderEpoch +

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235061965 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -4935,12 +4991,17 @@ class ReplicaManagerTest { topicPartition, leaderEpoch +

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1235057956 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -343,6 +348,7 @@ class ReplicaManagerTest { assertTrue(appendResult.hasFired)

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1233774289 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -342,9 +347,7 @@ class ReplicaManagerTest { rm.becomeLeaderOrFollower(1,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13868: MINOR: Close ReplicaManager correctly in ReplicaManagerTest

divijvaidya commented on code in PR #13868: URL: https://github.com/apache/kafka/pull/13868#discussion_r1233764248 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -84,7 +84,7 @@ import scala.jdk.CollectionConverters._ class ReplicaManagerTest {