[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1294402358 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -121,16 +122,18 @@ class PlaintextProducerSendTest extends

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1289780489 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1288249161 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -1862,7 +1884,35 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

divijvaidya commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1280547981 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -124,7 +124,7 @@ class PlaintextProducerSendTest extends BaseProducerSendTest