divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1543589903
@machi1990 since you opened a PR to fix this flaky test, you might be
familiar with this part of code. May I request you to review this PR please.
--
This is an automated message fr
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1102806383
Requesting review from @mjsax since you commented on the associated JIRA:
https://issues.apache.org/jira/browse/KAFKA-12319
Requesting review from @ijuma @jjkoshy since you fol
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1108621881
Hey @apovzner @dajac, did you get a chance to take a look at this? Please
let me know if I can make explanation simpler or if you have any questions.
--
This is an automated message
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1114879179
Thanks for checking @mimaison. As I explained above, the test is flaky since
the logic of computation of `Rate` has a bug and hence, in worst case scenario
it can exceed whatever thre
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1114895474
@mimaison Thinking about it, I can actually reduce the code changes such
that no modifications to any public interface is made. Do you still think a KIP
is required for this change in
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1119514099
CC'ing a couple of folks who may be interested to review this.
@mimaison @showuon @dengziming @apovzner @wyuka @satishd
--
This is an automated message from the Apache Git Se
