divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1142148171
@dengziming @hachikuji kindly review.
Reviewer(s) please note that all tests failing for this CI are known to be
flaky and are not related to this code change.
Test 1 - t
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1149994490
@hachikuji Please review. This should be a small one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1156349744
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1156349743
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
> Can this kind of problem be caught by spotbugs? manual checking is error
prone.
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1156352282
@mimaison perhaps you may want to look into this? This already has 2
approvals from non-committers.
--
This is an automated message from the Apache Git Service.
To respond to the me
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1163033464
@ijuma I have addressed your comments. This is ready for your review
(pending test run).
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1205402792
@tombentley requesting code review bandwidth from you here. We already have
3 non-committer approvals on this one.
--
This is an automated message from the Apache Git Service.
To r
divijvaidya commented on PR #12229:
URL: https://github.com/apache/kafka/pull/12229#issuecomment-1259755885
Rebased with the latest `trunk` to resolve merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th