[GitHub] [kafka] divijvaidya commented on pull request #12230: MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

2022-08-23 Thread GitBox
divijvaidya commented on PR #12230: URL: https://github.com/apache/kafka/pull/12230#issuecomment-1223768524 The failing tests for JDK 11 are unrelated to the code changes. ``` Build / JDK 11 and Scala 2.13 / testLargeAssignmentAndGroupWithNonEqualSubscription() –

[GitHub] [kafka] divijvaidya commented on pull request #12230: MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

2022-08-04 Thread GitBox
divijvaidya commented on PR #12230: URL: https://github.com/apache/kafka/pull/12230#issuecomment-1205399727 @showuon requesting for your code review time on this one. We already have two approvals from non-committers. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] divijvaidya commented on pull request #12230: MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

2022-08-03 Thread GitBox
divijvaidya commented on PR #12230: URL: https://github.com/apache/kafka/pull/12230#issuecomment-1203693391 @mimaison kindly review when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] divijvaidya commented on pull request #12230: MINOR: Catch InvocationTargetException explicitly and propagate underlying cause

2022-06-15 Thread GitBox
divijvaidya commented on PR #12230: URL: https://github.com/apache/kafka/pull/12230#issuecomment-1156355538 @dengziming @showuon please review this small change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the