[GitHub] [kafka] divijvaidya commented on pull request #13705: MINOR:Refactor the metric names into constants in ReplicaManager

2023-06-17 Thread via GitHub
divijvaidya commented on PR #13705: URL: https://github.com/apache/kafka/pull/13705#issuecomment-1595672796 Failing tests are unrelated. These are frequently failing tests in trunk. ``` [Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegra

[GitHub] [kafka] divijvaidya commented on pull request #13705: MINOR:Refactor the metric names into constants in ReplicaManager

2023-06-15 Thread via GitHub
divijvaidya commented on PR #13705: URL: https://github.com/apache/kafka/pull/13705#issuecomment-1593276292 > It seems that the failure of CI check has nothing to do with this pr. @divijvaidya Hmm...not sure about that. There are 99 tests failing and I am not comfortable saying that

[GitHub] [kafka] divijvaidya commented on pull request #13705: MINOR:Refactor the metric names into constants in ReplicaManager

2023-06-14 Thread via GitHub
divijvaidya commented on PR #13705: URL: https://github.com/apache/kafka/pull/13705#issuecomment-1591550112 I triggered the CI tests again since last run wasn't complete. Will merge this in after they are successful. -- This is an automated message from the Apache Git Service. To respond