[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1679415679 Unrelated test failures: ``` [Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()](https://ci-builds.apache.org/job/Kafka/job/kaf

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1679031173 @kamalcph tests are still failing [RemoteTopicCrudTest.testCreateRemoteTopicWithValidRetentionTime(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-1417

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1678685831 @kamalcph Tests from this PR are failing in CI such as `RemoteTopicCrudTest.testEnableRemoteLogOnExistingTopicTest`, see: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1676930952 accidentally approved this PR earlier, please ignore that. I am still waiting for another revision after the latest round of comments. -- This is an automated message from the Apach

[GitHub] [kafka] divijvaidya commented on pull request #14176: KAFKA-15295: Add config validation when remote storage is enabled on a topic

divijvaidya commented on PR #14176: URL: https://github.com/apache/kafka/pull/14176#issuecomment-1672922357 Regarding my previous comment: > where does kraft create topic and alter topic config invoke the validation because we seem to only be changing the controller config validation.