[GitHub] [kafka] dongjinleekr commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-11-17 Thread GitBox
dongjinleekr commented on a change in pull request #9414: URL: https://github.com/apache/kafka/pull/9414#discussion_r525845117 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java ## @@ -186,19 +186,29 @@ public void shouldRe

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-11-17 Thread GitBox
dongjinleekr commented on a change in pull request #9414: URL: https://github.com/apache/kafka/pull/9414#discussion_r525835354 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java ## @@ -140,9 +140,6 @@ public void sh

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-10-15 Thread GitBox
dongjinleekr commented on a change in pull request #9414: URL: https://github.com/apache/kafka/pull/9414#discussion_r505424665 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -301,6 +301,22 @@ public synchronized void