[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2022-07-08 Thread GitBox
dongjinleekr commented on PR #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-1179442940 @showuon Sorry for being late. Rebased onto the latest trunk, resolving the issues. > I think you can close this vote now since I'm also +1 binding now. :) OMG, What an

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-07-13 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-879085051 @kkonstantine It would be really great for me if this PR is included in 3.0, but it still needs one more binding +1. (It is also why it is prefixed with '[WIP]'.) Could

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-07-08 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-876498696 Hi @tombentley, Sorry for missing your comment on

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-22 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-864784408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-21 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-864950303 Hi @tombentley Here is the update. I added additional tests (`ReplicaVerificationToolTest#{testExitWithMultipleBrokerLists, testExitWithMultipleBootstrapServers`),

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-21 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-864784408 Rebased onto the latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-16 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-862070027 @tombentley Could you kindly have a look when you are free? :bowing_man: -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dongjinleekr commented on pull request #10827: [WIP] KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-16 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-862069060 Here it is. With rebasing onto the lastest trunk, I added unit tests that verify the command line parsing. Also, for this KIP is not passed yet (+2 bindings), I