[GitHub] [kafka] dplavcic commented on a diff in pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-18 Thread GitBox
dplavcic commented on code in PR #12505: URL: https://github.com/apache/kafka/pull/12505#discussion_r949392447 ## streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueStoreBuilderTest.java: ## @@ -126,27 +121,15 @@ public void shouldThrowNullPointerIfInnerIsNul

[GitHub] [kafka] dplavcic commented on a diff in pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-12 Thread GitBox
dplavcic commented on code in PR #12505: URL: https://github.com/apache/kafka/pull/12505#discussion_r944784869 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java: ## @@ -280,12 +276,9 @@ private StreamsConfig streamsConfigM

[GitHub] [kafka] dplavcic commented on a diff in pull request #12505: KAFKA-14133: Replace EasyMock with Mockito in streams tests

2022-08-12 Thread GitBox
dplavcic commented on code in PR #12505: URL: https://github.com/apache/kafka/pull/12505#discussion_r944781108 ## streams/src/test/java/org/apache/kafka/streams/state/internals/KeyValueStoreBuilderTest.java: ## @@ -126,27 +121,15 @@ public void shouldThrowNullPointerIfInnerIsNul