[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

2023-09-14 Thread via GitHub
drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1326808988 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig, // pause cleaning for

[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

2023-08-01 Thread via GitHub
drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1280393987 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig, // pause cleaning for

[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

2023-07-06 Thread via GitHub
drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1254020978 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig, // pause cleaning for

[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

2023-06-27 Thread via GitHub
drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1243863992 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig, // pause cleaning for

[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

2023-06-20 Thread via GitHub
drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1235172202 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig, // pause cleaning for

[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

2023-06-20 Thread via GitHub
drawxy commented on code in PR #13847: URL: https://github.com/apache/kafka/pull/13847#discussion_r1235160754 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -881,6 +881,7 @@ class ReplicaManager(val config: KafkaConfig, if