[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-11-18 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1320112618 Thanks @C0urante! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-08-11 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1212026332 Sorry for the wait on this—it looks like work to switch the test to Mockito is in flight now, so I’ll hang tight for now and rebase once that lands. I do have an account on the

[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-07-26 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1196168380 Hmm, if this is what you see than I have the same thing: ``` No tests found for given includes: [**/*Suite.class](exclude rules)

[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-07-22 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1192603682 @rhauch I see you merged a couple Connect pulls lately; can I bug you for this one as well? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-06-21 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1161765328 Cool, yeah, changing those annotations got everything working on my side too. (Sorry for the scare!) I took your suggestion verbatim and everything appears to work; I definitely

[GitHub] [kafka] dstelljes commented on pull request #12295: KAFKA-13586: Prevent exception thrown during connector update from crashing distributed herder

2022-06-20 Thread GitBox
dstelljes commented on PR #12295: URL: https://github.com/apache/kafka/pull/12295#issuecomment-1160666379 Hey @C0urante, thanks for the comments! I just added a variation on the update test for this, but it’s causing `testTaskRequestedZombieFencingForwardedToLeader` to hang locally.