[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-07 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916314304 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1112,9 +1121,10 @@ public synchronized RequestFuture maybeLeaveG

[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-07 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916314304 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1112,9 +1121,10 @@ public synchronized RequestFuture maybeLeaveG

[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-08 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916622548 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1050,10 +1051,18 @@ public synchronized void requestRejoin(final

[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-08 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916623215 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1112,9 +1121,10 @@ public synchronized RequestFuture maybeLeaveG

[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-08 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916680576 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java: ## @@ -1164,6 +1168,34 @@ public void testHandleNormalLeaveGroupResp

[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-08 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r916752022 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java: ## @@ -1164,6 +1168,34 @@ public void testHandleNormalLeaveGroupResp

[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-11 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r917905764 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1432,4 +1432,17 @@ public static String[] enumOptions(Class> enumClass) { .t

[GitHub] [kafka] etolbakov commented on a diff in pull request #12388: KAFKA-14013: Limit the length of the `reason` field sent on the wire

2022-07-11 Thread GitBox
etolbakov commented on code in PR #12388: URL: https://github.com/apache/kafka/pull/12388#discussion_r917938399 ## clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java: ## @@ -70,6 +70,21 @@ public static void validateGroupInstanceId(String id) {