[GitHub] [kafka] ex172000 commented on a diff in pull request #14093: KAFKA-15248 Add BooleanConverter

2023-07-29 Thread via GitHub
ex172000 commented on code in PR #14093: URL: https://github.com/apache/kafka/pull/14093#discussion_r1278454237 ## connect/runtime/src/test/java/org/apache/kafka/connect/converters/BooleanConverterTest.java: ## @@ -74,10 +74,12 @@ public void testFromConnectNull() { @Test

[GitHub] [kafka] ex172000 commented on a diff in pull request #14093: KAFKA-15248 Add BooleanConverter

2023-07-25 Thread via GitHub
ex172000 commented on code in PR #14093: URL: https://github.com/apache/kafka/pull/14093#discussion_r1274426209 ## connect/runtime/src/main/java/org/apache/kafka/connect/converters/BooleanConverterConfig.java: ## @@ -25,13 +25,13 @@ */ public class BooleanConverterConfig exte