flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1664880130
thx, already update jira status, and plz help review #13965 if could, thx.
@guozhangwang @philipnee
--
This is an automated message from the Apache Git Service.
To respond to the
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1663210404
> > I hadn't changed the logic, it is still a slow function. whether execute
performReassignments is checked by isBalanced, but it is not effective
previously and this pr just fix
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1659472862
> > I think the root cause is performReassignments in
GeneralAssignmentBuilder is a O(partSize * consumerNum) functions, it is very
inefficient.
>
> Ack, and with your changes,
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1657444761
> @flashmouse Thanks! I echo other's thoughts that in a unit test, we could
refrain ourselves from trying very large scale when trying to validate a
specific logic or expose a bug.
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1655170419
thx @ableegoldman
I reduce partitions num and increase consumers num, I think all tests
influenced by this pr should be PASSED now.
--
This is an automated message from the
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1653280547
It seems the tests I commit in this pr
(testAssignmentAndGroupWithNonEqualSubscriptionNotTimeout) have failure and
reason are all 90 second timeout.
emmm, should I make
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1651126636
@philipnee I do some modification follow by your review, but still some
incomprehension left, plz check my comment below your review, thx
--
This is an automated message from the
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1637362685
> @flashmouse thansk for the PR - I was the one who wrote the if-else if
-else block. I'm a bit surprised that I actually made this mistake, so I held
it off for a few days just to
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1633688874
> Hey @flashmouse - could you explain what do you mean by `useless loop`?
run while body in ``performReassignments`` but couldn't modify assignment
--
This is an automated
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1612747935
I found another one bug.
In
``org.apache.kafka.clients.consumer.internals.AbstractStickyAssignor#allSubscriptionsEqual``,
it would check whether one partition is assigned by
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1611815006
@dajac
we haven't seen such many rebalance times before, we before use
CooperativeSticky with kafka-client 3.0.0, rebalance times increase very slight.
but we are not use
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1611775967
@rreddy-22 that's what I mean, thank you, could any one merge this if
possible or help review to verify this pr is useful?
we are now using CooperativeSticky strategy in
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1610578143
@kirktrue thank you for reply!
In your case, although ``isBalanced`` return false,
``performReassignments`` still won't reassign any partition, because it would
only do
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1609178487
@divijvaidya thank you for reply!
the unit test
``org.apache.kafka.clients.consumer.internals.AbstractStickyAssignorTest#testLargeAssignmentAndGroupWithNonEqualSubscription``
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1608876813
@rajinisivaram @dajac plz have a look, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
15 matches
Mail list logo
