[GitHub] [kafka] g1geordie commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-15 Thread GitBox
g1geordie commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-760784911 There are no ignore test in those tests . @chia7712 can you check whether it satisfies your expectation or not ? ---

[GitHub] [kafka] g1geordie commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-15 Thread GitBox
g1geordie commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-761078614 @chia7712 thanks for all suggestions This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] g1geordie commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-21 Thread GitBox
g1geordie commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-764776835 @chia7712 sorry for late reply . I revert to` NotZstd` format . Can you help me take a look This is an au

[GitHub] [kafka] g1geordie commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-21 Thread GitBox
g1geordie commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-764776835 @chia7712 sorry for late reply . I revert to` NotZstd` format . Can you help me take a look This is an au

[GitHub] [kafka] g1geordie commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-28 Thread GitBox
g1geordie commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-769603195 @chia7712 Thank for your patch . I follow the style and change `MemoryRecordsBuilderTest` Can you help me take a look? :)

[GitHub] [kafka] g1geordie commented on pull request #9906: KAFKA-10885 Refactor MemoryRecordsBuilderTest/MemoryRecordsTest to avoid a lot of…

2021-01-31 Thread GitBox
g1geordie commented on pull request #9906: URL: https://github.com/apache/kafka/pull/9906#issuecomment-770622690 @chia7712 I have filled those `else` with `assertthrow`. What do you think ? This is an automated message f