[GitHub] [kafka] gaurav-narula commented on pull request #13949: KAFKA-15141: init logger statically on hot codepaths

2023-07-19 Thread via GitHub
gaurav-narula commented on PR #13949: URL: https://github.com/apache/kafka/pull/13949#issuecomment-1641606748 @divijvaidya Apologies for the late reply - I was away on vacation. I've rebased my changes against trunk. The JDK 17 build still failed though. I reckon it's due to unrelated

[GitHub] [kafka] gaurav-narula commented on pull request #13949: KAFKA-15141: init logger statically on hot codepaths

2023-07-04 Thread via GitHub
gaurav-narula commented on PR #13949: URL: https://github.com/apache/kafka/pull/13949#issuecomment-1620359732 > Interesting find! > > @gaurav-narula did you find this using a CPU profiler? For my curiosity, would it be possible to share the results of the profiler? Yes, this

[GitHub] [kafka] gaurav-narula commented on pull request #13949: KAFKA-15141: init logger statically on hot codepaths

2023-07-03 Thread via GitHub
gaurav-narula commented on PR #13949: URL: https://github.com/apache/kafka/pull/13949#issuecomment-1618518677 @gharris1727 Thank you for relating this with #9910 - I wasn't aware this was discussed previously. Coincidentally, my approach aligns with @ijuma's