[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

2021-10-08 Thread GitBox
guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r725149597 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -735,7 +735,6 @@ public void shouldComm

[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

2021-09-29 Thread GitBox
guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r718738299 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -704,11 +704,14 @@ public void sendOffsetsToTransacti

[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

2021-09-29 Thread GitBox
guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r718738299 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -704,11 +704,14 @@ public void sendOffsetsToTransacti

[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

2021-09-28 Thread GitBox
guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r717027686 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -189,14 +189,13 @@ void handleCorruption(fin

[GitHub] [kafka] guozhangwang commented on a change in pull request #11362: KAFKA-13319: Do not commit empty offsets on producer

2021-09-27 Thread GitBox
guozhangwang commented on a change in pull request #11362: URL: https://github.com/apache/kafka/pull/11362#discussion_r717027686 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -189,14 +189,13 @@ void handleCorruption(fin