[GitHub] [kafka] guozhangwang commented on a diff in pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-05-21 Thread GitBox
guozhangwang commented on code in PR #12035: URL: https://github.com/apache/kafka/pull/12035#discussion_r878743871 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1498,6 +1516,61 @@ public synchronized boolean close(final Duration timeout) throws

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-04-25 Thread GitBox
guozhangwang commented on code in PR #12035: URL: https://github.com/apache/kafka/pull/12035#discussion_r858263213 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration timeout) throws

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-04-25 Thread GitBox
guozhangwang commented on code in PR #12035: URL: https://github.com/apache/kafka/pull/12035#discussion_r857910667 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration timeout) throws

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-04-25 Thread GitBox
guozhangwang commented on code in PR #12035: URL: https://github.com/apache/kafka/pull/12035#discussion_r857908050 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration timeout) throws

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

2022-04-20 Thread GitBox
guozhangwang commented on code in PR #12035: URL: https://github.com/apache/kafka/pull/12035#discussion_r854451233 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1498,6 +1516,37 @@ public synchronized boolean close(final Duration timeout) throws