[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

2022-06-15 Thread GitBox
guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r880784817 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionStore.java: ## @@ -61,6 +65,18 @@ public QueryResult query(final Query

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

2022-06-02 Thread GitBox
guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r888483482 ## streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java: ## @@ -202,25 +205,43 @@ public void remove(final Windowed sessionKey)

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

2022-05-24 Thread GitBox
guozhangwang commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r880778694 ## streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java: ## @@ -39,6 +39,13 @@ */ public interface SessionStore extends StateStore,