[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-09-14 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r971010379 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamSelfJoin.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-09-13 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r970140299 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -305,6 +305,32 @@ public void buildAndOptimizeTopology(final

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-09-01 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r961002924 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -356,6 +381,95 @@ private void mergeDuplicateSourceNodes() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-09-01 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r960983275 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-31 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r959844687 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-31 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r959834484 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -356,6 +362,95 @@ private void mergeDuplicateSourceNodes() {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-30 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r958991975 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-30 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r958780670 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -270,16 +272,20 @@ private void maybeAddNodeForOptimizationMe

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12555: Optimize self-join

2022-08-27 Thread GitBox
guozhangwang commented on code in PR #12555: URL: https://github.com/apache/kafka/pull/12555#discussion_r956662529 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -356,6 +362,95 @@ private void mergeDuplicateSourceNodes() {