[GitHub] [kafka] guozhangwang commented on pull request #13319: MINOR: Fix flaky tests in DefaultStateUpdaterTest

2023-03-01 Thread via GitHub
guozhangwang commented on PR #13319: URL: https://github.com/apache/kafka/pull/13319#issuecomment-1451145318 Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] guozhangwang commented on pull request #13319: MINOR: Fix flaky tests in DefaultStateUpdaterTest

2023-03-01 Thread via GitHub
guozhangwang commented on PR #13319: URL: https://github.com/apache/kafka/pull/13319#issuecomment-1450565316 I checked the latest failure on `shouldPauseStandbyTaskAndNotTransit..` and found out that it's because of the test condition itself is timing dependent. What it wants to verify is t

[GitHub] [kafka] guozhangwang commented on pull request #13319: MINOR: Fix flaky tests in DefaultStateUpdaterTest

2023-03-01 Thread via GitHub
guozhangwang commented on PR #13319: URL: https://github.com/apache/kafka/pull/13319#issuecomment-1450512377 Honestly I do not quite understanding how mockito is messing here.. take `shouldPauseActiveTaskAndTransitToUpdateStandby` for example, after task1 (named topologyA) and task2 (named

[GitHub] [kafka] guozhangwang commented on pull request #13319: MINOR: Fix flaky tests in DefaultStateUpdaterTest

2023-02-28 Thread via GitHub
guozhangwang commented on PR #13319: URL: https://github.com/apache/kafka/pull/13319#issuecomment-1449254753 ping @cadonna @lucasbru for a quick review. Before this PR, local runs fail about 50% of the time; after this PR it succeeds with about 10 runs. -- This is an automated mess