[GitHub] [kafka] guozhangwang commented on pull request #13380: KAFKA-14468: Committed API

2023-03-29 Thread via GitHub
guozhangwang commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1489456338 Made another pass, do not have further comments. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] guozhangwang commented on pull request #13380: KAFKA-14468: Committed API

2023-03-23 Thread via GitHub
guozhangwang commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1482028180 @philipnee I made a third pass on the PR, but it seems we still have a few issues not fixed: 1) https://github.com/apache/kafka/pull/13380#discussion_r1146961554, 2)

[GitHub] [kafka] guozhangwang commented on pull request #13380: KAFKA-14468: Committed API

2023-03-17 Thread via GitHub
guozhangwang commented on PR #13380: URL: https://github.com/apache/kafka/pull/13380#issuecomment-1474361224 @philipnee let me know when it's ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the