guozhangwang commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-669664978
I've addressed the comments and here are the major changes:
1) do not delete checkpoint file upon loading it, and as a result simplify
the checkpointNeeded logic, initi
guozhangwang commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-669308138
System test green:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4093/
Ready for a final review and merge cc @mjsax
-
guozhangwang commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-668301971
cc @mjsax please take a final look.
This is an automated message from the Apache Git Service.
To respond to t
guozhangwang commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-664688329
@ableegoldman @vvcephei I've thought about controlling the frequency of
flushing, and I've decided to expose another public config to let users
specify. But I'd defer that to
