[GitHub] [kafka] hachikuji commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567203060 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -249,6 +270,7 @@ class KafkaApis(val requestChannel: RequestChannel, } def

[GitHub] [kafka] hachikuji commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567202218 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -119,7 +122,21 @@ class KafkaApis(val requestChannel: RequestChannel, type Fet

[GitHub] [kafka] hachikuji commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-29 Thread GitBox
hachikuji commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567201967 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -374,40 +374,4 @@ object LogConfig { MessageTimestampDifferenceMaxMsProp -> Kafk