[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

hachikuji commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r591870272 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -35,21 +34,14 @@ import scala.compat.java8.OptionConverters._ final class

[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

hachikuji commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r590758128 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -258,30 +251,62 @@ final class KafkaMetadataLog private ( } } -

[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

hachikuji commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r590634783 ## File path: raft/src/test/java/org/apache/kafka/snapshot/SnapshotsTest.java ## @@ -74,5 +79,44 @@ public void testInvalidSnapshotFilenames() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

hachikuji commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r582491373 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -92,4 +100,22 @@ public static Path createTempFile(Path logDir,

[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

hachikuji commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r582471506 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -299,7 +302,16 @@ final class KafkaMetadataLog private ( // If

[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

hachikuji commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r580705481 ## File path: raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java ## @@ -92,4 +93,13 @@ public static Path createTempFile(Path logDir,