[GitHub] [kafka] hachikuji commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-18 Thread GitBox
hachikuji commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r578870759 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -298,28 +342,30 @@ public void close() { public

[GitHub] [kafka] hachikuji commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-18 Thread GitBox
hachikuji commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r578870321 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java ## @@ -307,4 +309,38 @@ public int writeRecord(

[GitHub] [kafka] hachikuji commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-18 Thread GitBox
hachikuji commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r578675850 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -79,70 +82,111 @@ public BatchAccumulator( }

[GitHub] [kafka] hachikuji commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-16 Thread GitBox
hachikuji commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r577225891 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -79,67 +80,110 @@ public BatchAccumulator( }

[GitHub] [kafka] hachikuji commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-16 Thread GitBox
hachikuji commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r577216920 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -77,6 +79,29 @@ default void handleResign() {} */ void