[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r606034496 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r606034496 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605971389 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605971389 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java ## @@ -181,20 +212,36 @@ public boolean isDone() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-04-01 Thread GitBox
hachikuji commented on a change in pull request #10445: URL: https://github.com/apache/kafka/pull/10445#discussion_r605879590 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -689,30 +680,57 @@ private void completeBatch(Produce