[GitHub] [kafka] hachikuji commented on a change in pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

2021-12-07 Thread GitBox
hachikuji commented on a change in pull request #11046: URL: https://github.com/apache/kafka/pull/11046#discussion_r764255533 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -725,17 +725,13 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

2021-12-06 Thread GitBox
hachikuji commented on a change in pull request #11046: URL: https://github.com/apache/kafka/pull/11046#discussion_r763427186 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1176,7 +1176,8 @@ public void assign(Collection

[GitHub] [kafka] hachikuji commented on a change in pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

2021-11-29 Thread GitBox
hachikuji commented on a change in pull request #11046: URL: https://github.com/apache/kafka/pull/11046#discussion_r758867566 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1176,9 +1176,10 @@ public void assign(Collection

[GitHub] [kafka] hachikuji commented on a change in pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

2021-11-19 Thread GitBox
hachikuji commented on a change in pull request #11046: URL: https://github.com/apache/kafka/pull/11046#discussion_r753549068 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1235,9 +1236,15 @@ public void assign(Collection

[GitHub] [kafka] hachikuji commented on a change in pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

2021-11-18 Thread GitBox
hachikuji commented on a change in pull request #11046: URL: https://github.com/apache/kafka/pull/11046#discussion_r752683020 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -638,15 +636,15 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

2021-11-18 Thread GitBox
hachikuji commented on a change in pull request #11046: URL: https://github.com/apache/kafka/pull/11046#discussion_r752683020 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -638,15 +636,15 @@ public void

[GitHub] [kafka] hachikuji commented on a change in pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

2021-11-18 Thread GitBox
hachikuji commented on a change in pull request #11046: URL: https://github.com/apache/kafka/pull/11046#discussion_r752683020 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -638,15 +636,15 @@ public void