[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-08 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r765427639 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1887,15 +1891,21 @@ class KafkaConfig private(doLog: Boolean, val props: java.u

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-07 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r764232658 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1959,10 +1962,26 @@ class KafkaConfig private(doLog: Boolean, val props: java.u

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-07 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r764221288 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -748,7 +749,8 @@ object KafkaConfig { "Different security (SSL and SASL) set

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-07 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r764232658 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1959,10 +1962,26 @@ class KafkaConfig private(doLog: Boolean, val props: java.u

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-03 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r762175150 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -748,7 +749,8 @@ object KafkaConfig { "Different security (SSL and SASL) set

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760636630 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2018,12 +2015,104 @@ class KafkaConfig private(doLog: Boolean, val props: java.

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-12-01 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r760634593 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props: java.ut

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-11-30 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r759757667 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1960,9 +1962,16 @@ class KafkaConfig private(doLog: Boolean, val props: java.ut

[GitHub] [kafka] hachikuji commented on a change in pull request #11503: KAFKA-13456: Tighten KRaft config checks/constraints

2021-11-29 Thread GitBox
hachikuji commented on a change in pull request #11503: URL: https://github.com/apache/kafka/pull/11503#discussion_r758818012 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -2018,12 +2014,72 @@ class KafkaConfig private(doLog: Boolean, val props: java.u