hachikuji commented on a change in pull request #11745:
URL: https://github.com/apache/kafka/pull/11745#discussion_r804872295
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -725,13 +731,7 @@ class ControllerApis(val requestChannel: RequestChannel,
setErrorMessage("Duplicate topic name."))
topicNames.remove(topicName)
}
- val authorizedTopicNames = {
- if (hasClusterAuth) {
- topicNames.asScala
- } else {
- getCreatableTopics(topicNames.asScala)
- }
- }
+ val authorizedTopicNames = getAlterAuthorizedTopics(topicNames.asScala)
val topics = new util.ArrayList[CreatePartitionsTopic]
topicNames.forEach { topicName =>
if (authorizedTopicNames.contains(topicName)) {
Review comment:
Yeah, I think you're right. Even in the `KafkaApis` implementation, it
does not look like order would be preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
