[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r521760083 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java ## @@ -88,16 +80,11 @@ protected void updateErrorCounts(Map

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r520849832 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r519983517 ## File path: clients/src/main/java/org/apache/kafka/common/requests/EnvelopeRequest.java ## @@ -91,4 +91,14 @@ public AbstractResponse

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r519971686 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -1579,58 +1566,58 @@ private void

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r519955199 ## File path: clients/src/main/java/org/apache/kafka/common/requests/EnvelopeRequest.java ## @@ -91,4 +91,14 @@ public AbstractResponse

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518885497 ## File path: clients/src/main/java/org/apache/kafka/common/requests/EnvelopeRequest.java ## @@ -91,4 +91,14 @@ public AbstractResponse

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518885497 ## File path: clients/src/main/java/org/apache/kafka/common/requests/EnvelopeRequest.java ## @@ -91,4 +91,14 @@ public AbstractResponse

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518549809 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Writable.java ## @@ -33,6 +35,23 @@ void writeVarint(int i); void

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518532228 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Writable.java ## @@ -33,6 +35,23 @@ void writeVarint(int i); void

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518523253 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -1581,56 +1570,56 @@ private void

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518433135 ## File path: clients/src/main/resources/common/message/EnvelopeRequest.json ## @@ -23,7 +23,7 @@ "fields": [ { "name": "RequestData", "type":

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r518414400 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -89,10 +89,11 @@ public ResponseHeader toResponseHeader()