[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-02-22 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r580606013 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -2127,21 +2118,15 @@ class KafkaApisTest { error = Errors.NONE

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-21 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r561415958 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -371,9 +372,44 @@ class RequestChannel(val queueSize: Int,

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-20 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r561415958 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -371,9 +372,44 @@ class RequestChannel(val queueSize: Int,

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-20 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r561189636 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -227,37 +225,33 @@ class KafkaApisTest {

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-20 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r561175037 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -371,9 +372,44 @@ class RequestChannel(val queueSize: Int,

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-20 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r561174514 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java ## @@ -175,4 +175,19 @@ public String clientId() { public

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-19 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r560389436 ## File path: core/src/main/scala/kafka/server/RequestHandlerHelper.scala ## @@ -58,16 +57,68 @@ object RequestHandlerHelper { } } +class

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-19 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r560342977 ## File path: core/src/main/scala/kafka/server/RequestHandlerHelper.scala ## @@ -58,16 +57,68 @@ object RequestHandlerHelper { } } +class

[GitHub] [kafka] hachikuji commented on a change in pull request #9912: MINOR: Let TestRaftRequestHandler use RequestHandlerHelper

2021-01-19 Thread GitBox
hachikuji commented on a change in pull request #9912: URL: https://github.com/apache/kafka/pull/9912#discussion_r560342977 ## File path: core/src/main/scala/kafka/server/RequestHandlerHelper.scala ## @@ -58,16 +57,68 @@ object RequestHandlerHelper { } } +class