[GitHub] [kafka] hachikuji commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

2022-05-03 Thread GitBox
hachikuji commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r863942404 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1364,7 +1364,8 @@ Boolean isBrokerUnfenced(int brokerId) {

[GitHub] [kafka] hachikuji commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

2022-05-02 Thread GitBox
hachikuji commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r863259182 ## core/src/test/scala/unit/kafka/server/ControllerApisTest.scala: ## @@ -730,8 +729,45 @@ class ControllerApisTest { request.topics().add(new

[GitHub] [kafka] hachikuji commented on a diff in pull request #12106: KAFKA-13861: Fix the validateOnly behavior for CreatePartitions requests in KRaft mode

2022-04-29 Thread GitBox
hachikuji commented on code in PR #12106: URL: https://github.com/apache/kafka/pull/12106#discussion_r862113590 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1364,7 +1364,25 @@ Boolean isBrokerUnfenced(int brokerId) {