[GitHub] [kafka] hachikuji commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

2022-05-04 Thread GitBox
hachikuji commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r865377321 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -215,13 +215,17 @@ private void incrementalAlterConfigResource(ConfigRes

[GitHub] [kafka] hachikuji commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

2022-05-06 Thread GitBox
hachikuji commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r867248444 ## core/src/main/scala/kafka/server/ConfigAdminManager.scala: ## @@ -499,7 +499,8 @@ object ConfigAdminManager { .orElse(Option(ConfigDef.convertToString

[GitHub] [kafka] hachikuji commented on a diff in pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

2022-05-09 Thread GitBox
hachikuji commented on code in PR #12108: URL: https://github.com/apache/kafka/pull/12108#discussion_r868364470 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -118,6 +118,11 @@ class BrokerMetadataPublisher(conf: KafkaConfig, */ var _fir