[GitHub] [kafka] hachikuji commented on a diff in pull request #12150: KAFKA-13837; Return an error from Fetch if follower is not a valid replica

2022-05-18 Thread GitBox
hachikuji commented on code in PR #12150: URL: https://github.com/apache/kafka/pull/12150#discussion_r876119320 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1133,16 +1131,95 @@ class Partition(val topicPartition: TopicPartition, info.copy(leaderHwChange = if

[GitHub] [kafka] hachikuji commented on a diff in pull request #12150: KAFKA-13837; Return an error from Fetch if follower is not a valid replica

2022-05-17 Thread GitBox
hachikuji commented on code in PR #12150: URL: https://github.com/apache/kafka/pull/12150#discussion_r875267802 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1133,16 +1129,94 @@ class Partition(val topicPartition: TopicPartition, info.copy(leaderHwChange = if

[GitHub] [kafka] hachikuji commented on a diff in pull request #12150: KAFKA-13837; Return an error from Fetch if follower is not a valid replica

2022-05-17 Thread GitBox
hachikuji commented on code in PR #12150: URL: https://github.com/apache/kafka/pull/12150#discussion_r875267802 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1133,16 +1129,94 @@ class Partition(val topicPartition: TopicPartition, info.copy(leaderHwChange = if

[GitHub] [kafka] hachikuji commented on a diff in pull request #12150: KAFKA-13837; Return an error from Fetch if follower is not a valid replica

2022-05-17 Thread GitBox
hachikuji commented on code in PR #12150: URL: https://github.com/apache/kafka/pull/12150#discussion_r875267802 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1133,16 +1129,94 @@ class Partition(val topicPartition: TopicPartition, info.copy(leaderHwChange = if

[GitHub] [kafka] hachikuji commented on a diff in pull request #12150: KAFKA-13837; Return an error from Fetch if follower is not a valid replica

2022-05-17 Thread GitBox
hachikuji commented on code in PR #12150: URL: https://github.com/apache/kafka/pull/12150#discussion_r875249781 ## core/src/test/scala/unit/kafka/cluster/PartitionTest.scala: ## @@ -439,18 +545,33 @@ class PartitionTest extends AbstractPartitionTest { val leaderEpoch = 5