[GitHub] [kafka] hachikuji commented on a diff in pull request #12249: MINOR; Test last committed record offset for Controllers

Mon, 06 Jun 2022 12:19:00 -0700 


hachikuji commented on code in PR #12249:
URL: https://github.com/apache/kafka/pull/12249#discussion_r890468231


##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerMetricsTest.java:
##########
@@ -40,9 +40,11 @@ public void testKafkaControllerMetricNames() {
             "GlobalPartitionCount",
             "OfflinePartitionsCount",
             "PreferredReplicaImbalanceCount",
+            "LastAppliedRecordLagMs",
             "LastAppliedRecordOffset",
             "LastAppliedRecordTimestamp",
-            "LastAppliedRecordLagMs");
+            "LastCommittedRecordOffset"

Review Comment:
   There are a few metrics which are not covered int this test. We can do it 
separately, but I wonder if it would make sense to expose the names in an enum 
or something so that we can get some of the basic testing for free.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to