[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-22 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r952055798 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -167,8 +167,18 @@ public enum MetadataVersion { public static fina

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-22 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r952030392 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-19 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r950502736 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -188,12 +182,16 @@ private ApiError updateFeature( } }

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-19 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r950487364 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) { } }

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-19 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r950458081 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) { } }

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-19 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r950450852 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-19 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r95035 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] hachikuji commented on a diff in pull request #12513: MINOR: some fixes to the KRaft bootstrap logic

2022-08-18 Thread GitBox
hachikuji commented on code in PR #12513: URL: https://github.com/apache/kafka/pull/12513#discussion_r949590579 ## metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java: ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un