[GitHub] [kafka] hachikuji commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-18 Thread GitBox
hachikuji commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1073904486 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -390,7 +390,7 @@ class ReplicaManager(val config: KafkaConfig, // epoch, a sentinel val

[GitHub] [kafka] hachikuji commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-17 Thread GitBox
hachikuji commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1072693482 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaCon

[GitHub] [kafka] hachikuji commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-12 Thread GitBox
hachikuji commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1068783227 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaCon

[GitHub] [kafka] hachikuji commented on a diff in pull request #13107: KAFKA-13972; Ensure replica state deleted after reassignment cancellation

2023-01-12 Thread GitBox
hachikuji commented on code in PR #13107: URL: https://github.com/apache/kafka/pull/13107#discussion_r1068783227 ## core/src/main/scala/kafka/controller/ControllerChannelManager.scala: ## @@ -436,17 +436,22 @@ abstract class AbstractControllerBrokerRequestBatch(config: KafkaCon