[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1207028405 ## core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala: ## @@ -113,38 +142,113 @@ class ProducerIdManagerTest { }

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1206088849 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -61,27 +63,59 @@ class ProducerIdsIntegrationTest {

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1199413525 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +130,107 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1170301813 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -207,35 +234,38 @@ class RPCProducerIdManager(brokerId: Int, }) } + //

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1169133482 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1169036716 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110464884 ## server-common/src/main/java/org/apache/kafka/server/common/ProducerIdsBlock.java: ## @@ -32,11 +34,25 @@ public class ProducerIdsBlock { private final int

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1110463718 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def